This repository has been archived by the owner on Mar 22, 2018. It is now read-only.
added Dockerfile #65
Open
added Dockerfile #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| && ln -sf /usr/local/share/phantomjs-1.9.7-linux-x86_64/bin/phantomjs /usr/bin/phantomjs | ||
|
|
||
| ADD . /app | ||
| RUN rm -rf /app/.git && cd /app && npm install |
|
Could you add a line about this dockerfile in the README? |
added 2 commits
December 6, 2014 15:44
…irectory to screenshot-as-a-service, and removed maintainer line.
|
@fzaninotto thanks for reviewing my pull request. I went ahead and made the requested changes, as well as added some docker info to readme. A note about the .git directory: The reason I remove it during the build process(Dockerfile), is because that directory is inside the docker image. It's not necessary to keep it inside of the docker image because those files will never be modified directly. Instead, you would make changes to the files in your regular git repo outside of the docker image(your local file system), and then rebuild the docker image. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.